Change git config scope from global to system #1193
Closed
+75
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can retry this PR with a check if the action is run in container or not? That should fix this |
|
@liskin Sorry, it's been a while and I don't quite remember the details, but I do remember this approach does not work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1169
The
/github/home/.gitconfigdoes not seem to exist in the container even aftergit checkout. As a result, the project directory (with.gitdirectory in it) will not be considered as a safe directory and any further action that relies on agitwill fail.This PR will change the scope of
git configcommand fromglobaltosystem.