Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id diff missing on step workflow check-dist #1205

Open
alexquitiaquez opened this issue Mar 9, 2023 · 1 comment
Open

id diff missing on step workflow check-dist #1205

alexquitiaquez opened this issue Mar 9, 2023 · 1 comment

Comments

@alexquitiaquez
Copy link

Hi,
I found that this condition is not working steps.diff.conclusion == 'failure' cause there is no id for previous step that does the comparison

if: ${{ failure() && steps.diff.conclusion == 'failure' }}

All you need is to add the id: diff between these two lines

- name: Compare the expected and actual dist/ directories
run: |

Without that, the action upload-artifact will never upload the artifact dist/

thanks

@alexquitiaquez
Copy link
Author

I opened a PR #1206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant