v4 with default config (no with) does not include --progress flag

[bquorning]

After upgrading to actions/checkout@v4 (no with configuration), we see¹ show-progress: true listed in the logs, but git fetch is run without the --progress flag.

I think this is not the intended behavior of #1067, which says

Note that the default value of this new option is true, which matches the current behavior, so this PR introduces no behavior change unless the new option is explicitly present and set to false.

Footnotes

1. https://github.com/rubocop/rubocop-rspec/actions/runs/6076842370/job/16485526462 ↩

[riseshia]

#1454 might fix this

[nedbat]

I understand the desire to keep old behavior, but why does anyone need to see dozens of lines of progress percentages? Since @v4 seems to have changed the default (by accident), why no just admit that no progress is the better default and leave it that way?

[bquorning]

I too prefer the less noisy (accidental) default.

[simonbaird]

Ooh, sorry about that. I think the original version of #1067 predates the new options handling and somehow when rebasing and resolving conflicts I didn't notice the way the default value wasn't preserved. (In hindsight an inverted option might have been better, e.g. "hideProgress" instead of "showProgress".)

[cbandera]

Hi what is the status of this issue? Has it been fixed in the meanwhile? I'm not sure whether I understand your comments but the referneced pr #1454 does not seem to have been merged.

[riseshia]

Based on the threads so far, I concluded that maintainers is not interested in this bug, and I don't want to keep a PR opened long long time, so closed #1454 a few days ago. I still have willing to contribute for this if requested, but leave this for more passionate someone.