Pass showProgress to fetchOptions #1454
Closed
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riseshia
force-pushed
the
pass-sp-to-fo
branch
from
8e6fd99 to
0a9f64d
Compare
takost
approved these changes
Sep 6, 2023
riseshia
force-pushed
the
pass-sp-to-fo
branch
from
0a9f64d to
1608921
Compare
riseshia
force-pushed
the
pass-sp-to-fo
branch
from
1608921 to
f329bef
Compare
|
Conflict resolved. Could anybody check this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1453
#1067 seems not to pass
showProgressto fetchOptions, which makes any fetch call handled without--progressConfirmed works correctly with default / explicitly given show-progress option, here is test result
https://github.com/riseshia/actions-playground/actions/runs/6078541181
I don't add test for this, because I couldn't find proper place for this case(most test are unit testing, but this problem is from "passing" arg) 🤔
any suggestion for adding test is welcome. ;)