Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the warning about needing to have git in the PATH more obvious #325

Open
yasinuslu opened this issue Aug 11, 2020 · 2 comments
Open

Comments

@yasinuslu
Copy link

Hi, thanks for developing this action and GitHub Actions in general, it's truly amazing.

This is more like a suggestion than an issue, I was trying to execute some git commands in the workflow and kept receiving this error:

fatal: not a git repository (or any parent up to mount point /)

I did some debugging here and there, then I finally checked out the logs of actions/checkout@v2 and saw this warning.

The repository will be downloaded using the GitHub REST API
To create a local Git repository instead, add Git 2.18 or higher to the PATH

At first it didn't occur to me that the checkout would just fetch the repository with REST API, I only thought about it after eliminating other factors. I just saw that it's mentioned in the documentation, now I'm not sure if I should create this issue or not :) It might be more helpful to make that warning more visible, let's discuss if anyone can think of a way to make it more obvious to save time for someone that might stumble upon the same issue in the future.

If you think it's obvious the way it is then we can close the issue.

@yasinuslu yasinuslu changed the title A warning about needing to install git before the checkout Make the warning about needing to have git in the PATH more obvious Aug 11, 2020
@yasinuslu
Copy link
Author

Maybe we can put that error message in the README so that when someone googles the error ends up reading the warning. Actually this issue can also serve that purpose I guess.

@yasinuslu
Copy link
Author

yasinuslu commented Aug 11, 2020

Here is an idea for GitHub in general unrelated to this issue. I'm not an SEO expert so I'm not sure if this is possible. But maybe there could be a feature in GitHub to indicate like {{problem}} => {{solution}} in an issue and then somehow that issue can be found easily with a similar google search like this {{repo-name}} {{problem}}. If that's possible that would be a huge improvement for developers. Just my two cents. If that's not possible with SEO, then GitHub can have this feature in the internal search engine.

For example there could be a huge discussion in an issue, somewhere in the line one comment could be a potential solution. If there would be a feature like this, then we can just jump to the issue with a search and then quickly skim through comments that were marked as a potential solution. And then use the time we saved for actually developing our project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant