Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What determines if --no-tags or --tags is used in the git fetch of this action? #40

Closed
nelsonjchen opened this issue Sep 13, 2019 · 5 comments

Comments

@nelsonjchen
Copy link

I'm trying to introduce GitHub actions to a repository that uses git describe --tags as a step. For some reason, the fetches on a private repository of my organization does a fetch with --no-tags.
My experiments in an experimental repo with the tagging feature inside GitHub show it fetching with --tags. The logic of this action isn't contained in the source code of this repo so I'm not sure why it's doing this kind of fetch. If this is a difference in behavior between lightweight tags and annotated tags, this behavior should be documented.

@TingluoHuang
Copy link
Member

@nelsonjchen
actions/checkout@v1 should always fetch with --tags, there was a bug last week where we accidentally change the behavior to --no-tags without bumping the action's version.
We reverted the change, but due to a setting error, a small set of customers didn't get the revert.
I noticed the setting problem a few hours back and fix it, so everyone uses checkout@v1 gets the same behavior which is git fetch --tags.

@nelsonjchen
Copy link
Author

Alright. Whew. OK, this explains today's fun. Thanks for the reply.

FYI: @ctranquill

@TingluoHuang
Copy link
Member

Sorry for the trouble 😭

@nelsonjchen
Copy link
Author

I can safely say the pain brought us closer. It's all good.

@xt0rted
Copy link

xt0rted commented Oct 3, 2019

@TingluoHuang I'm looking for a way to use --no-tags but only see a v1 of this action, will a v2 be released with this option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants