Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule option not working #51

Closed
giordi91 opened this issue Oct 2, 2019 · 3 comments
Closed

Submodule option not working #51

giordi91 opened this issue Oct 2, 2019 · 3 comments

Comments

@giordi91
Copy link

giordi91 commented Oct 2, 2019

Good afternoon, I am using the checkout with sumbodule cloning like this:

- uses: actions/checkout@v1
      with:
        submodules: true

It does not seem to be recrusive, I have submodule that has submodules of its own.
If I run git submodule update --init --recursive then I get everything I need, with just the submodule:true flag that does not seem to be the case.

Am I doing something wrong?
My submodule is this one:
https://github.com/GPUOpen-Tools/Compressonator

@nulano
Copy link

nulano commented Oct 2, 2019

#34, #43, #44, and #48 suggest using submodules: recursive for this.

@giordi91
Copy link
Author

giordi91 commented Oct 3, 2019

Ah thank you!I only checked for the open issues not for the closed one. Thank you!
I am just a bit confused from the merged PR seems it should have made it to master but can't see it in the action.yml file?

@giordi91 giordi91 closed this as completed Oct 3, 2019
@nulano
Copy link

nulano commented Oct 3, 2019

Those PRs are still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants