Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git submodules 'remote' option #645

Open
Iliyan-Petrov-IBM opened this issue Dec 2, 2021 · 4 comments
Open

Git submodules 'remote' option #645

Iliyan-Petrov-IBM opened this issue Dec 2, 2021 · 4 comments

Comments

@Iliyan-Petrov-IBM
Copy link

Iliyan-Petrov-IBM commented Dec 2, 2021 •
edited
Loading

Hi Experts,

I would like to request an additional option that will add the parameter --remote to the "git submodule update" command. This parameter is really important because it will get the latest commit coming from the git submodule. If it is missing then the there is a big chance the git submodule to be checked out in detached HEAD different than the latest commit.

Best Regards,
Iliyan Petrov
@jdpipe
Copy link

jdpipe commented Dec 4, 2021 •
edited
Loading

Hi there... I may have an issue related to this one. I have a repository from which I have forked (https://github.com/OpenModelica/OpenModelica.git). My fork is https://github.com/jdpipe/OpenModelica.git. This repository uses various submodules, one of which I wanted to fork and then modify. My forked submodule is https://github.com/jdpipe/OMCompiler-3rdParty.git. I have updated the gitmodules file to point to this new submodule.

Here's the problem though... when I attempt to check out my forked copy of the OpenModelica repository, it is failing to pick up my settings for the submodule OMCompiler-3rdParty, and is picking up OpenModelica/OMCompiler-3rdParty instead of my jdpipe/OMCompiler-3rdParty.

I think there could be a bug in the actions/checkout code. Perhaps it is not good at getting submodules in nested subdirectories (this submodule lives in OMCompiler/3rdParty, not at the top level). Or perhaps it is struggling becuase I referenced the submodule using ssh instead of https. Or perhaps as Ilyan suggests, it some issue with not fetching the latest commit???

Not sure if you can access this output, but the results of my actions/checkout effort are here:
https://github.com/jdpipe/OpenModelica/runs/4416183797

@Dr-Electron
Copy link

We would love to have that feature too. We are building a website consisting of multiple submodules where we would need to fetch the newest version of the submodule

@Supermajestcd Supermajestcd mentioned this issue Jan 21, 2023
Open
@ImpossibleShape
Copy link

Would also like to see this feature.

ouuan added a commit to OI-wiki/OI-wiki that referenced this issue Feb 15, 2024
@ouuan
ci: give up using actions/checkout for export
381014f 
actions/checkout#645

还要手动 remote submodule 的话感觉手动 clone 也没差（
ouuan added a commit to OI-wiki/OI-wiki that referenced this issue Feb 16, 2024
@ouuan
ci(build-pdf-typst): auto fetch latest deps (#5412)
8177c56 
* ci(build-pdf-typst): refine workflows & auto fetch latest deps

* ci: give up using actions/checkout for export

actions/checkout#645

还要手动 remote submodule 的话感觉手动 clone 也没差（

* ci(build-pdf-typst): set GH_TOKEN for gh cli

* ci(build-pdf-typst): fix lxgw-wenkai extraction

* ci(build-pdf-typst): use typst-community/setup-typst and --font-path

* ci(build-pdf-typst): mkdir .fonts

* ci(build-pdf-typst): fix tar arguments order

* ci: rename export artifacts
@koalo
Copy link

koalo commented May 8, 2024

It would be also very helpful for GitHub actions that run e.g. daily to track if everything still builds and runs with upstream changes in submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jdpipe @koalo @Dr-Electron @Iliyan-Petrov-IBM @ImpossibleShape