Check for symlinked gitconfig #651
Open
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to edit the user's actual gitconfig, we only want to copy their setup. If the file is symlinked, we resolve the link and copy the source file instead.
|
Any thoughts on this? |
|
looks better to me |
|
Can we get this merged then |
|
I encountered the same issue. Would it be possible to merge this pull request? |
|
How is this still not merged after 2 years? |
|
@jww3 any chance we can get this in? |
|
I also had the same issue. |
|
this is till happening and it's a big issue on golang projects which relies on the git config so private modules can be properly downloaded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to edit the user's actual gitconfig, we only want to copy their setup.
If the file is symlinked, we resolve the link and copy the source file instead.
This resolves #650