Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Script Injection Attack #1041

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Prevent Script Injection Attack #1041

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe77b19
Prevent Script Injection Attack
norwd Dec 12, 2022
d86d1a4
Merge branch 'main' into patch-1
norwd Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Prevent Script Injection Attack 
The user provided inputs here are vulnerable to script injection. This PR uses an intermediary environment variable to treat the input as a string, rather than as part of the command.

See: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable
  • Loading branch information
@norwd
norwd authored Dec 12, 2022
commit fe77b196f4824137f0a7d8c1e6a2f443dbd4f7b3
7 changes: 5 additions & 2 deletions .github/workflows/update-main-version.yml
View file
Original file line number Diff line number Diff line change
@@ -16,6 +16,9 @@ on:
jobs:
tag:
runs-on: ubuntu-latest
env:
TARGET: ${{ github.event.inputs.target }}
MAIN_VERSION: ${{ github.event.inputs.main_version }}
steps:
- uses: actions/checkout@v3
with:
@@ -25,6 +28,6 @@ jobs:
git config user.name github-actions
git config user.email github-actions@github.com
- name: Tag new target
run: git tag -f ${{ github.event.inputs.main_version }} ${{ github.event.inputs.target }}
run: git tag -f "$MAIN_VERSION" "$TARGET"
- name: Push new tag
run: git push origin ${{ github.event.inputs.main_version }} --force
run: git push origin "$MAIN_VERSION" --force