Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take global core.sshCommand into consideration #1066

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lultimouomo
Copy link

git-auth-helper.ts overwrites core.sshCommand to pass custom parameters to ssh, but in doing so, it overwrites the base command with the output of io.which('ssh', true), which I assume just looks for ssh in the path; if the git configuration specifies a custom ssh command, git-auth-helper.ts should instead append custom parameters to the existing custom command.

@lultimouomo lultimouomo requested a review from a team as a code owner January 4, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants