Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid auth configuration for submodules when settings.submodules is false ( rebased #424 ) auth submodules #1321

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Avoid auth configuration for submodules when settings.submodules is false ( rebased #424 ) auth submodules #1321

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
55709ff
GH#354 Disabled auth submodules config when related setting is false
cosimo Jan 13, 2021
27cd406
GH#354 Updated dist/index.js build
cosimo Jan 13, 2021
fbc7451
Revert "GH#354 Updated dist/index.js build"
cosimo Jan 13, 2021
b9935aa
Tried to fix the "unstaged changes" test failure
cosimo Jan 13, 2021
1bf7689
Update dist/index.js with changes
kaidokert May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tried to fix the "unstaged changes" test failure 
Error: Unstaged changes detected. Locally try running: git clean -ffdx && npm ci && npm run format && npm run build
Error: Process completed with exit code 1.

Rebased PR from #424
  • Loading branch information
@cosimo @kaidokert
cosimo authored and kaidokert committed May 15, 2023
commit b9935aab1f1f1374eb0a1281a4654c8fc4d669c0
6 changes: 4 additions & 2 deletions dist/index.js
View file
Original file line number Diff line number Diff line change
@@ -7589,8 +7589,10 @@ class GitAuthHelper {
core.warning(`Failed to remove '${configKey}' from the git config`);
}
}
const pattern = regexpHelper.escape(configKey);
yield this.git.submoduleForeach(`git config --local --name-only --get-regexp '${pattern}' && git config --local --unset-all '${configKey}' || :`, true);
if (this.settings.submodules) {
const pattern = regexpHelper.escape(configKey);
yield this.git.submoduleForeach(`git config --local --name-only --get-regexp '${pattern}' && git config --local --unset-all '${configKey}' || :`, true);
}
});
}
}