Add support to customize working directory #1493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes! This is badly needed in our use case. |
|
Any chance this could get a review? |
|
@ericsciple this would be awesome to get added |
|
Hello, |
interifter
approved these changes
Dec 18, 2023
|
Merge |
|
Is there any tracking regarding this PR? |
WiehanVanNiekerk
approved these changes
Feb 23, 2024
|
@jww3 Please can you assist |
|
Related/possible duplicate issues: #955 |
Let user override $GITHUB_WORKSPACE as default working directory Defaults to undefined, the original behaviour is maintained
Add working-directory input parameter
Add working-directory
Not needed (working-directory option is used internally)
Remove path.sep during comparison with repositoryPath (did not take in account root folders) Updated and added more unit tests Updated dist/index.js
accodev
force-pushed
the
feature/customizable-working-dir
branch
from
4cd8c93 to
8461fff
Compare
ember-ana
added a commit
to FunkinCrew/ci-checkout
that referenced
this pull request
Jul 20, 2024
|
any update with that? its still unresolved, what is blocking merging this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the users to customize the working directory where the commands of the action will be executed, e.g.: c:, /home/user, etc.
This is to allow the users to switch to a different mount point (for example github hosted windows runners offer quite a bit of space but the checkout process happens on d:, where the space is only 14GB).
Sometimes it is not feasible to copy the repository after cloning it because:
I have added a few unit tests and tested it on a windows-latest runner on this repository:
https://github.com/accodev/trackmania-manager-py/actions/runs/6263454133/job/17007891987
Note that the chosen working directory has to exists (kept the original behaviour).