-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set initial-branch (#427) #465
base: main
Are you sure you want to change the base?
Conversation
@ericsciple: is there something I need to do to get this considered? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer a shorter name, and I would have much preferred a proper analysis why this change is safe (instead, I was forced to perform that analysis myself, from scratch, and I imagine that this is the problem that prevents the team from merging this PR: it just asks for too much effort on the reviewers' side).
Having said that, I would not mind this PR being merged as-is, I would merely prefer above-mentioned issues to be addressed.
@hross what do I need to do to move this forward? |
@ericsciple @TingluoHuang ping? |
@vanZeben is there something that can be done to move this along? |
Looks like this stalled. Are there other suggestions on silencing this warning? It shows up quite a few times. |
@kbrock: I can rebase and you can use my fork that has the fix. Otherwise, you could technically create an action / wrapper /step that does:
|
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
My opinions on this:
And remember that just like @dscho I'm not a maintainer (and not even a contributor), just a developer very interested in this PR going forward and eventually being accepted. It's been more than an year guys! (PS: @jsoref , you might mark your conversation with @dscho as resolved, it would be one less red status on the pending items summary, this might incentivize a reviewer . And maybe ping an actual (human) maintainer/reviewer, as that |
I'm happy to pick any name that a codeowner suggests. Personally I use Anyway, I'm more than happy to update this (or any of my other PRs) although I'm about to be relatively unavailable for a bit. |
I suggest you preemptively change the branch name now to something shorter, such as your |
Fixes #427
Suppress noise about that git itself is changing its default branch. When
actions/checkout
is used, it will always be given a specific branch (or similar) to check things out, and thus the default branch is not used...Run actions/checkout@v2.0.0
See #465 (comment) for a proof.