Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'checkout pull request HEAD' example work for non-PRs #712

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

2opremio
Copy link

@2opremio 2opremio commented Mar 2, 2022

The example, as is, breaks when the action needs to run both in PRs and other events.

@@ -184,7 +184,7 @@ When Git 2.18 or higher is not in your PATH, falls back to the REST API to downl
```yaml
- uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}
ref: ${{ github.event.pull_request.head.sha || github.ref }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be even better to make this github.sha instead? This removes the non-determinism which is introduced by having to resolve the ref at the time the step runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants