Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'checkout pull request HEAD' example work for non-PRs #712

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make 'checkout pull request HEAD' example work for non-PRs #712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
@@ -184,7 +184,7 @@ When Git 2.18 or higher is not in your PATH, falls back to the REST API to downl
```yaml
- uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}
ref: ${{ github.event.pull_request.head.sha || github.ref }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be even better to make this github.sha instead? This removes the non-determinism which is introduced by having to resolve the ref at the time the step runs.

```

## Checkout pull request on closed event