Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated String.prototype.substr() #720

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/git-command-manager.ts
Original file line number Diff line number Diff line change
@@ -294,7 +294,7 @@ class GitCommandManager {
line = line.trim()
if (line.startsWith('ref:') || line.endsWith('HEAD')) {
return line
.substr('ref:'.length, line.length - 'ref:'.length - 'HEAD'.length)
.slice('ref:'.length, line.length - 'HEAD'.length)
.trim()
}
}
4 changes: 2 additions & 2 deletions src/git-directory-helper.ts
Original file line number Diff line number Diff line change
@@ -64,11 +64,11 @@ export async function prepareExistingDirectory(
if (ref) {
ref = ref.startsWith('refs/') ? ref : `refs/heads/${ref}`
if (ref.startsWith('refs/heads/')) {
const upperName1 = ref.toUpperCase().substr('REFS/HEADS/'.length)
const upperName1 = ref.toUpperCase().slice('REFS/HEADS/'.length)
const upperName1Slash = `${upperName1}/`
branches = await git.branchList(true)
for (const branch of branches) {
const upperName2 = branch.substr('origin/'.length).toUpperCase()
const upperName2 = branch.slice('origin/'.length).toUpperCase()
const upperName2Slash = `${upperName2}/`
if (
upperName1.startsWith(upperName2Slash) ||
12 changes: 6 additions & 6 deletions src/misc/generate-docs.ts
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ function updateUsage(
const newReadme: string[] = []

// Append the beginning
newReadme.push(originalReadme.substr(0, startTokenIndex + startToken.length))
newReadme.push(originalReadme.slice(0, startTokenIndex + startToken.length))

// Build the new usage section
newReadme.push('```yaml', `- uses: ${actionReference}`, ' with:')
@@ -68,9 +68,9 @@ function updateUsage(
// Longer than width? Find a space to break apart
let segment: string = description
if (description.length > width) {
segment = description.substr(0, width + 1)
segment = description.slice(0, width + 1)
while (!segment.endsWith(' ') && !segment.endsWith('\n') && segment) {
segment = segment.substr(0, segment.length - 1)
segment = segment.slice(0, -1)
}

// Trimmed too much?
@@ -84,14 +84,14 @@ function updateUsage(
// Check for newline
const newlineIndex = segment.indexOf('\n')
if (newlineIndex >= 0) {
segment = segment.substr(0, newlineIndex + 1)
segment = segment.slice(0, newlineIndex + 1)
}

// Append segment
newReadme.push(` # ${segment}`.trimRight())

// Remaining
description = description.substr(segment.length)
description = description.slice(segment.length)
}

if (input.default !== undefined) {
@@ -113,7 +113,7 @@ function updateUsage(
newReadme.push('```')

// Append the end
newReadme.push(originalReadme.substr(endTokenIndex))
newReadme.push(originalReadme.slice(endTokenIndex))

// Write the new README
fs.writeFileSync(readmePath, newReadme.join(os.EOL))
4 changes: 2 additions & 2 deletions src/ref-helper.ts
Original file line number Diff line number Diff line change
@@ -278,6 +278,6 @@ function select(obj: any, path: string): any {
return obj[path]
}

const key = path.substr(0, i)
return select(obj[key], path.substr(i + 1))
const key = path.slice(0, i)
return select(obj[key], path.slice(i + 1))
}