Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't remove auth if submodules are off #833

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: Don't remove auth if submodules are off #833

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2738cc
Fix: Don't remove auth if submodules are off
sevenc-nanashi Jun 20, 2022
51ffdcd
Fix: Fix Syntax
sevenc-nanashi Jun 20, 2022
110353e
Merge branch 'main' into patch-1
sevenc-nanashi Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/git-auth-helper.ts
View file
Original file line number Diff line number Diff line change
@@ -364,11 +364,13 @@ class GitAuthHelper {
}
}

const pattern = regexpHelper.escape(configKey)
await this.git.submoduleForeach(
// wrap the pipeline in quotes to make sure it's handled properly by submoduleForeach, rather than just the first part of the pipeline
`sh -c "git config --local --name-only --get-regexp '${pattern}' && git config --local --unset-all '${configKey}' || :"`,
true
)
if (this.settings.submodules) {
const pattern = regexpHelper.escape(configKey)
await this.git.submoduleForeach(
// wrap the pipeline in quotes to make sure it's handled properly by submoduleForeach, rather than just the first part of the pipeline
`sh -c "git config --local --name-only --get-regexp '${pattern}' && git config --local --unset-all '${configKey}' || :"`,
true
)
}
}
}