Support downloading multiple artifacts #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support multiline inputs we need to upgrade the '@actions/core' NPM package to version v1.10.0.
It's smart to keep the NodeJS version pinned so we can run all build jobs consistently. Otherwise, we might run into some versions mismatch like below: ``` npm ERR! While resolving: @typescript-eslint/parser@2.30.0 npm ERR! Found: eslint@7.4.0 npm ERR! node_modules/eslint npm ERR! dev eslint@"^7.4.0" from the root project npm ERR! peer eslint@"^5.0.0 || ^6.0.0 || ^7.0.0" from @typescript-eslint/eslint-plugin@4.11.1 npm ERR! node_modules/@typescript-eslint/eslint-plugin npm ERR! @typescript-eslint/eslint-plugin@">=2.25.0" from eslint-plugin-github@4.1.1 npm ERR! node_modules/eslint-plugin-github npm ERR! dev eslint-plugin-github@"^4.1.1" from the root project npm ERR! 7 more (@typescript-eslint/experimental-utils, ...) npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer eslint@"^5.0.0 || ^6.0.0" from @typescript-eslint/parser@2.30.0 npm ERR! node_modules/@typescript-eslint/parser npm ERR! dev @typescript-eslint/parser@"^2.30.0" from the root project npm ERR! @typescript-eslint/parser@">=2.25.0" from eslint-plugin-github@4.1.1 npm ERR! node_modules/eslint-plugin-github npm ERR! dev eslint-plugin-github@"^4.1.1" from the root project npm ERR! npm ERR! Conflicting peer dependency: eslint@6.8.0 npm ERR! node_modules/eslint npm ERR! peer eslint@"^5.0.0 || ^6.0.0" from @typescript-eslint/parser@2.30.0 npm ERR! node_modules/@typescript-eslint/parser npm ERR! dev @typescript-eslint/parser@"^2.30.0" from the root project npm ERR! @typescript-eslint/parser@">=2.25.0" from eslint-plugin-github@4.1.1 npm ERR! node_modules/eslint-plugin-github npm ERR! dev eslint-plugin-github@"^4.1.1" from the root project ```
As new dependency versions were installed, we need to update/create the metadata files cached by Licensed. https://github.com/github/licensed/blob/master/docs/commands/status.md#cached-dependency-record-not-found
There is a few use cases where we want to download a few different artifacts but not all of them. This commit implements this support, without breaking backward compatibility. Two build test cases were also added to the pipeline.
This1righthere
approved these changes
Nov 7, 2022
|
steps:
|
karimali54
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.