Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using node18 to support centOS 7 runners #257

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dhawalseth
Copy link

To support CentOS 7 that is not compatible with node20, we need to keep a fork of v4 release that would work with centOS 7 self-hosted runners

Ref issue: actions/runner#2906

@dhawalseth dhawalseth requested a review from a team as a code owner December 18, 2023 18:50
@dlemstra
Copy link

Node 16 is end of life. But I think it would be wise to switch to node 18 to maintain compatibility with older operating systems. I personally think the move to node20 was to early. I would expect GitHub to use the oldest LTS version. This switch to node 20 has broken some of my builds where I need to check if my binaries still work on older Docker images. All of them work with node 18 but no longer work with node 20 because that requires a recent glibc version. I understand a switch back to node 16 would not be possible but can we please switch back to node 18?

@dhawalseth dhawalseth changed the title Using node16 to support centOS 7 runners Using node18 to support centOS 7 runners Jan 4, 2024
@dhawalseth
Copy link
Author

Node 16 is end of life. But I think it would be wise to switch to node 18 to maintain compatibility with older operating systems. I personally think the move to node20 was to early. I would expect GitHub to use the oldest LTS version. This switch to node 20 has broken some of my builds where I need to check if my binaries still work on older Docker images. All of them work with node 18 but no longer work with node 20 because that requires a recent glibc version. I understand a switch back to node 16 would not be possible but can we please switch back to node 18?

Sounds good. can move to node18. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants