Add warn-on-failure #286
Add warn-on-failure #286
Conversation
| core.setOutput( | ||
| 'failure', | ||
| `Unable to download artifact(s): ${err.message}` | ||
| ) |
There was a problem hiding this comment.
How about using a warning annotation instead? https://github.com/actions/toolkit/tree/main/packages/core#annotations
There was a problem hiding this comment.
No. Because I can't as a consuming action or a consuming workflow retrieve that without extra permissions and fishing through the logs.
If I'm the consuming action/workflow, I can use the output and then produce my own annotation if I decide it's relevant to my use case.
There was a problem hiding this comment.
For demonstration purposes, I could include that in the test.yml to show that it works...
Some users might not want their workflow jobs to die just because an artifact isn't available...
jsoref
force-pushed
the
warn-on-failure
branch
from
8c95d84 to
bd6ef41
Compare
| - name: Log missing warning | ||
| env: | ||
| output: ${{ steps.request-missing-artifact.outputs.failure }} | ||
| run_os: ${{ matrix.runs-on }} | ||
| run: | | ||
| echo "::notice title=This message is expected::[$run_os] $output" | ||
| shell: bash |
There was a problem hiding this comment.
This demonstrates the ability for consuming workflows to take advantage of the output and report it in whichever way they see fit.
|
Is this ever going to be reviewed? |
Some users might not want their workflow jobs to die just because an artifact isn't available...
fixes #285
closes #42, closes #208, closes #254