Add allow-not-found input argument #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robherley As of now, there still seem to be proponents of this feature. Is there a chance that this is still going to be included or are there other plans currently? |
DaUs3103
approved these changes
May 14, 2024
|
@DaUs3103 Thanks for reviewing! I wasn't sure how to interpret your comment, should I update the README.md and CHANGELOG.md files as well? |
croemheld
force-pushed
the
allow-not-found
branch
from
4c276b4 to
a0b83ea
Compare
|
@croemheld I think he's saying update the README because any new option that gets added needs to be documented so users know it's an available option. |
croemheld
force-pushed
the
allow-not-found
branch
from
a0b83ea to
2ef3ffc
Compare
croemheld
force-pushed
the
allow-not-found
branch
from
13e115e to
49b3eab
Compare
|
@DaUs3103 @rrundle-dave Sorry for the long delay, I rebased on top of the latest changes and updated the README.md file with the new input argument as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42
This PR adds the
allow-not-foundinput argument todownload-artifactthat, when set totrue, will not fail the action when an artifact with the specifiednameinput argument is not found.If the artifact is not found, the output of
download-pathof the action will contain an empty string instead of the would-be download path. This can be checked in the subsequent step via${{ steps.<id>.outputs.download-path != '' }}as can be seen in the updated workflow test.yml file. Additionally, a warning is printed viacore.warningif the artifact is not found whileallow-not-foundis set to true.If
allow-not-foundis set to false (default behavior), the action behaves as it did before this PR.