Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Recommended Permissions #373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Recommended Permissions #373

wants to merge 1 commit into from

Conversation

KyFaSt
Copy link

@KyFaSt KyFaSt commented Jan 22, 2025

To reduce risk of over-privileged tokens, we are adding recommended permissions to popular GitHub-owned Actions READMEs. Please confirm these permissions are correct and merge the change. Thank you!

To reduce risk of over-privileged tokens, we are adding recommended permissions to popular GitHub-owned Actions READMEs
@KyFaSt KyFaSt requested a review from a team as a code owner January 22, 2025 02:32
The `actions/download-artifact` workflow relies on an internal authentication pattern and does not use the GITHUB_TOKEN, to reduce risk of over-privileged token, jobs that use `actions/download-artifact` should set permissions to none:

```yaml
perm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the YAML here is invalid


# Recommended Permissions

The `actions/download-artifact` workflow relies on an internal authentication pattern and does not use the GITHUB_TOKEN, to reduce risk of over-privileged token, jobs that use `actions/download-artifact` should set permissions to none:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to actions/cache#1536 (comment), I'm worried this language will mislead users to setting up a workflow with no permissions that would likely fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants