Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeRequestedReviewers api do not remove CODEOWNER teams #520

Closed
PSinha1202 opened this issue Jan 26, 2025 · 5 comments
Closed

removeRequestedReviewers api do not remove CODEOWNER teams #520

PSinha1202 opened this issue Jan 26, 2025 · 5 comments

Comments

@PSinha1202
Copy link

Describe the bug
I tried using a PAT token which has admin access to a repo. The api succeed and it removed all teams and users but do not removed CODEOWNER team. I am not understanding why. As per the documentation, there is not exception mentioned to this doc.
https://docs.github.com/en/rest/pulls/review-requests?apiVersion=2022-11-28#remove-requested-reviewers-from-a-pull-request

To Reproduce
Steps to reproduce the behavior:

`
await github.rest.pulls.removeRequestedReviewers({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: pull_request.number,
reviewers: pendingUserReviewers,
team_reviewers: pendingTeamReviewers
});

pendingTeamReviewers: [CODEOWNER TEAMS and Other TEAMS]

`

Expected behavior
All pendingTeamReviewers, should be removed including CODEOWNER TEAMS

Screenshots

Image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@PSinha1202
Copy link
Author

Appreciate if this ticket can get some attenion.

@joshmgross
Copy link
Member

👋 This is not the right place to ask questions about the GitHub API.

The GitHub Community or Support would be better places for this type of question.

https://github.com/orgs/community/discussions

@PSinha1202
Copy link
Author

I am not sure why , when i am using the removeRequestedReviewers which is part of github-script am i missing something?

@joshmgross
Copy link
Member

This action does not control the behavior of the GitHub API - it is just a tool to interact with it.

@PSinha1202
Copy link
Author

I see, thanks for the input. Have added my views to the above link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants