Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace WebClient with Invoke-WebRequest #11180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

replace WebClient with Invoke-WebRequest #11180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion images/macos/scripts/helpers/Common.Helpers.psm1
View file
Original file line number Diff line number Diff line change
@@ -84,7 +84,7 @@ function Invoke-DownloadWithRetry {
for ($retries = 20; $retries -gt 0; $retries--) {
try {
$attemptStartTime = Get-Date
(New-Object System.Net.WebClient).DownloadFile($Url, $Path)
Invoke-WebRequest -Uri $Url -Outfile $Path
$attemptSeconds = [math]::Round(($(Get-Date) - $attemptStartTime).TotalSeconds, 2)
Write-Host "Package downloaded in $attemptSeconds seconds"
break
2 changes: 1 addition & 1 deletion images/ubuntu/scripts/helpers/Common.Helpers.psm1
View file
Original file line number Diff line number Diff line change
@@ -133,7 +133,7 @@ function Invoke-DownloadWithRetry {
for ($retries = 20; $retries -gt 0; $retries--) {
try {
$attemptStartTime = Get-Date
(New-Object System.Net.WebClient).DownloadFile($Url, $DestinationPath)
Invoke-WebRequest -Uri $Url -Outfile $DestinationPath
$attemptSeconds = [math]::Round(($(Get-Date) - $attemptStartTime).TotalSeconds, 2)
Write-Host "Package downloaded in $attemptSeconds seconds"
break
2 changes: 1 addition & 1 deletion images/windows/scripts/helpers/InstallHelpers.ps1
View file
Original file line number Diff line number Diff line change
@@ -184,7 +184,7 @@ function Invoke-DownloadWithRetry {
for ($retries = 20; $retries -gt 0; $retries--) {
try {
$attemptStartTime = Get-Date
(New-Object System.Net.WebClient).DownloadFile($Url, $Path)
Invoke-WebRequest -Uri $Url -Outfile $Path
$attemptSeconds = [math]::Round(($(Get-Date) - $attemptStartTime).TotalSeconds, 2)
Write-Host "Package downloaded in $attemptSeconds seconds"
break
Loading
Oops, something went wrong.