Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Disable rustup self-updating #11722

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sureshe456
Copy link
Contributor

@sureshe456 sureshe456 commented Mar 4, 2025

Description

  1. Disable rustup self-updating.
    issue-11714

Related issue:

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@sureshe456 sureshe456 requested a review from erik-bershel March 4, 2025 09:43
RUSTUP_VERSION="1.27.1" # Set the Rustup version to pin

echo "Installing Rustup version $RUSTUP_VERSION..."
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain=$RUSTUP_VERSION
Copy link

@Noratrieb Noratrieb Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct, --default-toolchain concerns the Rust version, not Rustup version.

@Noratrieb
Copy link

thank you for working on this, but it's now no longer necessary as a fix has been released: https://blog.rust-lang.org/2025/03/04/Rustup-1.28.1.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants