Replies: 15 comments 34 replies
-
|
Happy to hear that GitHub finally had response on this. |
Beta Was this translation helpful? Give feedback.
-
|
it's really disappointing that this is has only been communicated this recently, and that most issues relating to this have been closed for months. #2255 It's also disappointing that github can both not support any later version than 16 in an action, while demanding a minimum version of 18 to use octokit. https://github.com/octokit/octokit.js/#fetch-missing Please can this be reconsidered? |
Beta Was this translation helpful? Give feedback.
-
|
I have also raised an issue in octokit octokit/octokit.js#2505 |
Beta Was this translation helpful? Give feedback.
-
|
Hey! Really sorry this has come about :( I just want to clarify, if we are able to accelerate a move to node20 would this solve this for you? (our preference is still to get as far ahead as we can as we know it's Actions that has lagged here 😞 ) |
Beta Was this translation helpful? Give feedback.
-
|
That would certainly be appreciated thanks, but I think more important would be coordination between the various teams to keep a consistent set of supported node versions. |
Beta Was this translation helpful? Give feedback.
-
|
@nebuk89 thanks for your accelerated release of node 20. |
Beta Was this translation helpful? Give feedback.
-
|
This is great to hear! Thanks a lot! One small suggestion: It took me a bit of googling and browsing various github actions issues to find this post. As for #2704 (comment): For now you can either use const fetch = require('node-fetch').default;
const octokit = new Octokit({ auth: token, request: {fetch: fetch, } });Or you can make a composite action with With composite actions in inputs:
my_parameter:
description: 'My input'
required: falseAnd after setting up env:
INPUT_MY_PARAMETER: ${{ inputs.my_parameter }}If you need, I have those in more detail in Node16 and Node18 branches of one of my actions. Now, with the upcoming support for |
Beta Was this translation helpful? Give feedback.
-
|
while this is a very helpful comment and workaround, I don't think this is a reasonable expectation on githubs part. |
Beta Was this translation helpful? Give feedback.
-
|
@AWare Did PoC with workaround a while ago, see: https://github.com/orgs/community/discussions/53217#discussioncomment-6227341 |
Beta Was this translation helpful? Give feedback.
-
|
Since Node 20 won't be LTS until Can you share any updates on if your team is making any process changes to ensure this doesn't happen in the future? Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
Node20 support has been merged #2732 by the runner team It is now only a matter of waiting for the next runner release, if nobody reverts it |
Beta Was this translation helpful? Give feedback.
-
|
@ChristopherHX Thanks for the heads-up! I couldn't see any documentation PR in the pipeline, but maybe |
Beta Was this translation helpful? Give feedback.
-
|
@MikeMcC399 You should not make use of node20 until 14th September if released on 14th August.
So yes it's better to wait longer. Azure Devops allowed to specify node16 + node20 (prefer newer node) to be backward compatible, while GitHub decided removing this feature(while forking the agent/runner in 2019, this was never possible it Github Actions). |
Beta Was this translation helpful? Give feedback.
-
Absolutely! This is a breaking change and needs a new major release version number for any published action using it. |
Beta Was this translation helpful? Give feedback.
-
|
Do you have any update for us on the release date for Node.js |
Beta Was this translation helpful? Give feedback.
-
|
My question was answered in #2619 (comment)
|
Beta Was this translation helpful? Give feedback.
-
|
I have now successfully used |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
Documentation |
Beta Was this translation helpful? Give feedback.
-
|
In your original post in July 2023 you wrote:
That is currently the first and last post in this discussion from any maintainer. The milestone of Node.js
|
Beta Was this translation helpful? Give feedback.
-
|
The list of questions is mostly answered in https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ The only unanswered question is:
|
Beta Was this translation helpful? Give feedback.
-
|
Eventually you will be forced onto to the "lowest node version we support" with an appropriate warning so you know it is happening. I'll make sure it is clear in future communications, thanks for the feedback @MikeMcC399 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks very much for explaining about what will happen with older versions. That makes absolute sense! One more feedback point: GitHub Actions: Transitioning from Node 16 to Node 20 Sep 22, 2023 announced "Our plan is to transition all actions to run on Node 20 by Spring 2024." Using northern hemisphere seasons is not a globally compatible way of naming time-frames. Spring 2024 is 6 months later in the southern hemisphere compared to the northern hemisphere. If you use months (or month ranges like Apr - Jun) or calendar quarters, like second calendar quarter 2024 for instance, that would be correct over the whole globe. |
Beta Was this translation helpful? Give feedback.
-
|
The blog post states
But the actions platform still states Node12 as a valid option if you use the wrong argument for the |
Beta Was this translation helpful? Give feedback.
-
|
If a runner specifies
So it can still be specified as a parameter but Does that make sense? |
Beta Was this translation helpful? Give feedback.
-
BTW, this exception is thrown by |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
According to the blog post GitHub Actions: Transitioning from Node 16 to Node 20 Sep 22, 2023 I would expect to see warnings now for
Has there been a change or delay to the plan? |
Beta Was this translation helpful? Give feedback.
-
|
I can already see such warnings in a recent run. Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache/restore@v3, actions/cache/save@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for sharing! It seems to be a staged-rollout in that case. I just ran a workflow which contained |
Beta Was this translation helpful? Give feedback.
-
|
Thanks again! I am now receiving the deprecation warnings as expected. 🙂 |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
Can someone shed some light on the plan with GHES? We are on GHES 3.10.3 and the latest runner provided there is 2.304.0 (indicated in the 'New Runner' page and also auto-upgrade). But for node20 we need 2.308.0. GHES 3.11 is "only" in RC and also typically our internal IT does not upgrade directly. As actions in the market are moving to node20 things start to get tricky as we need bugfixes only provided on new versions already targeting node20. |
Beta Was this translation helpful? Give feedback.
-
|
According to actions/upload-artifact#444 (comment) from @joshmgross
As far as I can see, the last related blog entry is https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ from Sep 22, 2023 and this says:
which has no mention about the warning having been disabled. I couldn't find any related update in https://github.com/orgs/community/discussions/categories/actions either. What is the plan for re-enabling the |
Beta Was this translation helpful? Give feedback.
-
|
👋 Hey @MikeMcC399, thanks for the ping. I'll find someone who can provide at timeline. |
Beta Was this translation helpful? Give feedback.
-
|
Hey @MikeMcC399 , we want to heavily encourage upgrading to node 20. The warnings will be coming back on in the next couple of weeks, alongside the full removal of node 16 in spring 2024. Node 16 workflows at that time will then automatically run on node 20, with a warning to users to let them know. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @thboop Thank you very much for sharing the plans! That is very helpful. 👍🏻 |
Beta Was this translation helpful? Give feedback.
-
|
I'm seeing the warning on GitHub-hosted runners appearing again. |
Beta Was this translation helpful? Give feedback.
-
|
There is a new GitHub blog post GitHub Actions; All Actions will run on Node20 instead of Node16 by default announcing that all actions will be forced to run under Node.js |
Beta Was this translation helpful? Give feedback.
-
|
Hello, found this discussion while searching around a bit - is support for Node 22 on the roadmap? https://github.com/actions/setup-node added support for Node 22 as of https://github.com/actions/node-versions/releases/tag/22.0.0-8879734543, yet the runner errors when configured to use Node 22 in https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runsusing-for-javascript-actions:
|
Beta Was this translation helpful? Give feedback.
-
|
Ran into this today - it's a pretty significant use case, IMO, in that it would support actions to be written in TypeScript and use |
Beta Was this translation helpful? Give feedback.
-
|
@muzimuzhi is this a relevant repo/issue to discuss support for |
Beta Was this translation helpful? Give feedback.
-
|
relevant issue seems to be neglected #3600 |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
@MikeMcC399 fair enough, I've asked people who've driven nodejs22 support #2732 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
Sorry for the slowness on what comes next after node20! I was out for a few months but now I am back I will pick up with the team and start the annual wheel turn of moving up our node versions :D |
Beta Was this translation helpful? Give feedback.
-
|
@nebuk89 any issue or pr to follow for status updates? |
Beta Was this translation helpful? Give feedback.
-
👋 Hey all!
Sorry we've been quiet on this. I want to provide you with as much clarity as we have right now on the next steps for node.
Node 12
We've been on the path to deprecate this for a while, we started back in October with a deprecation message. We are super relieved 😅 that we will be removing Node12 from the Actions runner on the 14th of August 2023. This has taken a while because a bunch of folks were still actively using node12 and we wanted to give them heads up and migrate as many of them as we could, in advance.
Node 16 and 20
From here, we plan to skip over node 18 and hop on the node 20 LTS release. We are currently working on a date to rollout node 20 and have work in-flight to accomplish this. We will update this discussion in the coming weeks with our plans once we finalize them.
This does mean that we will carry node 16 past it's out-of-support date, but will start the deprecation process of node 16 later this year, similar to how we deprecated node 12 over a period of time.
Thank you all for your engagement and feedback on this matter! Please keep raising issues in our repo when you have concerns or feedback. We really appreciate the engagement and support ❤️ .
Beta Was this translation helpful? Give feedback.
All reactions