Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regularize notation #1112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Regularize notation #1112

wants to merge 1 commit into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented May 23, 2021

The docs https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions clearly indicate ::.

I understand a previous iteration of the environment may have used ##[...], but the current one does not, and messages should reflect how users are supposed to use things today.

@jsoref jsoref requested a review from a team as a code owner May 23, 2021 13:12
@jsoref
Copy link
Contributor Author

jsoref commented May 23, 2021

Fwiw, without this change, I have a workflow which used an action which did: echo ::set-output:: and it triggered this:

workflow Unable to process command '::set-output::' successfully.
workflow Required field 'name' is missing in ##[set-output] command.

Which is pretty clearly wrong.

fhammerl
fhammerl previously approved these changes Jun 8, 2021
@jsoref jsoref dismissed stale reviews from ghost and fhammerl via a98c797 December 22, 2021 16:29
@jsoref
Copy link
Contributor Author

jsoref commented Oct 7, 2022

@fhammerl do i need to do something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants