-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide option to specify arguments for container jobs and services #1152
base: main
Are you sure you want to change the base?
Conversation
Another example is parity substrate. This container requires an argument, else an error is returned:
vs
So without being able to add any arguments, it's impossible to have substrate as a service. |
bumping this in case it moves it up the queue in many cases, the 'local emulator' image for key cloud services can only be configured with command line parameters. this is a primary use-case for the a user can work around that by building their own image with an overridden CMD/ENTRYPOINT, but it would be so much better for actions to expose this ability directly; it is core docker functionality there are multiple requests for this out in the wild:
gitlab has had this for decades: https://docs.gitlab.com/ee/ci/docker/using_docker_images.html#override-the-entrypoint-of-an-image |
Hello, Building, and Maintaining custom images everytime we want to pass a specific entrypoint is extremely painful. Any news regarding the merge of this PR for passing custom CMD/entrypoints to container services? |
Hey, any update on this? Service containers are unusable to me as is without being able to override CMD. |
bump - is this good to go? lgtm |
@AllanGuigou @TingluoHuang @rentziass @benwells |
When specifying service containers for a jobs, sometimes it is necessary to add command line arguments to the container. See this example: https://github.community/t/how-do-i-properly-override-a-service-entrypoint/17435. Here it is useful to add
--listen-client-urls http://0.0.0.0:2379 --advertise-client-urls http://0.0.0.0:2379
to the container start command line.These arguments are simply passed after the image name on the
docker create
command line.Here is another example of trying to add command line arguments to postgres: https://stackoverflow.com/questions/65438055/how-to-add-config-args-to-postgres-service-container-in-github-action
The
options
field cam be used to change the entrypoint of a container, but it is not possible to change the arguments.Please let me know what else is required to make this mergable, thank you.