Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the out-of-date warning message. #3595

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Improve the out-of-date warning message.
In case of self-hosted runner, the organization uses the
GitHub runner, but they also have their own self-hosted runner
"version", with specific configuration being improved over time
and through this increasing their own internal "runner version".

The way the message was written, sometimes results in
confusion, where developer and a devops person start mistakenly
assuming that the version is related to their own runner version,
and not the actual GitHub runner that runs on that hardware.
Time is then lost, until someone realizes that this has nothing
to do with the internal "runner version" itself, but with the
actual GitHub runner that needs to be upgraded.

Message was fixed to explicitely differentiate between
"GitHub runner" and the self-hosted runner itself to avoid
possible confusion and possibly save someone few minutes of time.
  • Loading branch information
tecimovic committed Nov 26, 2024
commit 20b214419a43b5cc2337627438e9227a2d5b2c82
2 changes: 1 addition & 1 deletion src/Runner.Worker/JobRunner.cs
Original file line number Diff line number Diff line change
@@ -511,7 +511,7 @@ private async Task WarningOutdatedRunnerAsync(IExecutionContext jobContext, Pipe

if (result == TaskResult.Failed && warnOnFailedJob)
{
jobContext.Warning($"This job failure may be caused by using an out of date self-hosted runner. You are currently using runner version {currentVersion}. Please update to the latest version {serverPackages[0].Version}");
jobContext.Warning($"This job failure may be caused by using an out of date version of GitHub runner on your self-hosted runner. You are currently using GitHub runner version {currentVersion}. Please update to the latest version {serverPackages[0].Version}");
}
else if (warnOnOldRunnerVersion)
{