Use POSIX syntax for fatal function def
#697
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I invoked this script from a `/bin/sh` script, as `./create-latest-svc.sh`, and got:
```
./create-latest-svc.sh: 43: ./create-latest-svc.sh: Syntax error: "(" unexpected
```
The Bash version on this machine is `GNU bash, version 5.0.3(1)-release (x86_64-pc-linux-gnu) `.
`man bash` seems to indicate the parentheses are optional, so I'm not sure why it's complaining. The POSIX shell command language ([here](https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_09_05) doesn't keywordize `function`, but does require parens:
```
foo() {
...
}
```
While I'm not 100% sure what set of modes Bash has that's causing it to reject the `function` + parens syntax, removing the bashism and using POSIX syntax should be generally compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I invoked this script from a
/bin/shscript, as./create-latest-svc.sh, and got:The Bash version on this machine is
GNU bash, version 5.0.3(1)-release (x86_64-pc-linux-gnu).man bashseems to indicate the parentheses are optional, so I'm not sure why it's complaining. The POSIX shell command language (here doesn't keywordizefunction, but does require parens:While I'm not 100% sure what set of modes Bash has that's causing it to reject the
function+ parens syntax, removing the bashism does fix it for me. ¯_(ツ)_/¯