Skip to content

Commit

Permalink
v3 - Remove azureedge.net fallback logic and update install scrip…
Browse files Browse the repository at this point in the history
…ts (#573)

* Remove logic for azureedge.net fallback in preparation for install script changes (v3)

* remove fallback in index.js

* fix ci

* add updated install scripts

* Update e2e-tests.yml

* Update e2e-tests.yml to remove outdated URLs in workflow

* Fix audit issues

* Revert audit fixes for heap memory failures

---------

Co-authored-by: HarithaVattikuti <73516759+HarithaVattikuti@users.noreply.github.com>
  • Loading branch information
zaataylor and HarithaVattikuti authored Feb 20, 2025
1 parent ea9897a commit b2ace4b
Showing 5 changed files with 221 additions and 269 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
@@ -409,7 +409,7 @@ jobs:
runs-on: ubuntu-22.04
env:
https_proxy: http://no-such-proxy:3128
no_proxy: github.com,dotnetcli.blob.core.windows.net,download.visualstudio.microsoft.com,api.nuget.org,dotnetcli.azureedge.net
no_proxy: github.com,download.visualstudio.microsoft.com,api.nuget.org,builds.dotnet.microsoft.com,ci.dot.net
steps:
- name: Checkout
uses: actions/checkout@v3
9 changes: 1 addition & 8 deletions dist/setup/index.js
Original file line number Diff line number Diff line change
@@ -71264,13 +71264,7 @@ class DotnetVersionResolver {
allowRetries: true,
maxRetries: 3
});
let response;
try {
response = yield httpClient.getJson(DotnetVersionResolver.DotNetCoreIndexUrl);
}
catch (error) {
response = yield httpClient.getJson(DotnetVersionResolver.DotnetCoreIndexFallbackUrl);
}
const response = yield httpClient.getJson(DotnetVersionResolver.DotNetCoreIndexUrl);
const result = response.result || {};
const releasesInfo = result['releases-index'];
const releaseInfo = releasesInfo.find(info => {
@@ -71286,7 +71280,6 @@ class DotnetVersionResolver {
}
exports.DotnetVersionResolver = DotnetVersionResolver;
DotnetVersionResolver.DotNetCoreIndexUrl = 'https://builds.dotnet.microsoft.com/dotnet/release-metadata/releases-index.json';
DotnetVersionResolver.DotnetCoreIndexFallbackUrl = 'https://dotnetcli.azureedge.net/dotnet/release-metadata/releases-index.json';
class DotnetCoreInstaller {
constructor(version, quality) {
this.version = version;
Loading
Oops, something went wrong.

0 comments on commit b2ace4b

Please sign in to comment.