Add support for node version codenames and keywords #58
+507
−401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored for optimization and maintainability
|
Suggestion: Since the refactoring done in this PR interferes with #42, I could also incorporate those changes in this PR. Edit: I also didn't update |
Closed
|
|
|
This PR seems to have a lot of out of scope changes in it. |
|
Not going to update it if it's not going to be merged. |
|
Why is this not merged? It would be important to me to indicate that I want my tests to run on the latest LTS node version. Right now I need to update it everywhere by hand. |
|
Fixed in #270 |
krzyk
pushed a commit
to krzyk/setup-node
that referenced
this pull request
Apr 11, 2023
Feature/DEVPOPS-903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26
This PR adds support for node codenames (
argon,boronetc) and selected keywords (latest,current,lts).Resolving the codenames and keywords is fully automated and ensures future codenames support.
In order to do so, I took the liberty to refactor the code and test cases for better optimization and maintainability.
I'm aware that code reviewing will be a nightmare because of the many changes. I suggest having a look at the new code itself instead, to have a better understanding of it.
In case the refactoring is not acceptable, I'll try to provide a PR with minimum changes, but the code will be ugly.