Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recommended release strategy #35

Closed
damccorm opened this issue Aug 19, 2019 · 1 comment
Closed

Use recommended release strategy #35

damccorm opened this issue Aug 19, 2019 · 1 comment

Comments

@damccorm
Copy link
Contributor

We should be using the release strategy specified by https://github.com/actions/toolkit/blob/master/docs/action-versioning.md#recommendations

To get there, we need to:

  1. Create a releases/v1 branch and move the v1 tag and future releases there
  2. Warn that we will deprecate the master branch and that you should attach to v1 instead. We will support master in a warned but deprecated state for ~1 month.
  3. Switch the warning to an error on master. Remove node_modules from the master branch. We will stay in this state for ~1 month.
  4. Remove the error on master.

During steps 2 and 3, we need to be extra careful to not check the warning/error into the releases branch.

@bryanmacfarlane
Copy link
Member

We're not doing this. Instead, we're moving toward ncc and packing. Will open a separate issue

krzyk pushed a commit to krzyk/setup-node that referenced this issue Apr 11, 2023
deining pushed a commit to deining/setup-node that referenced this issue Nov 9, 2023
…riev

docs: add yelizariev as a contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants