Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note using recommended gitignore #30

Closed
fulldecent opened this issue Aug 15, 2019 · 1 comment · Fixed by #40
Closed

Note using recommended gitignore #30

fulldecent opened this issue Aug 15, 2019 · 1 comment · Fixed by #40
Assignees
@damccorm

Comments

@fulldecent
Copy link
Contributor

GitHub publishes a recommended gitignore for NodeJS projects at https://github.com/github/gitignore/blob/master/Node.gitignore

That approach is not used here. Which is fine.

Please reference the best practice used for departing from the above gitignore, preferably at the top of the gitignore here.
@damccorm damccorm mentioned this issue Aug 22, 2019
Merged
@damccorm
Copy link
Contributor

Added #40 to address this - thanks for the feedback!

@damccorm damccorm self-assigned this Aug 22, 2019
krzyk pushed a commit to krzyk/setup-node that referenced this issue Apr 11, 2023
@bradforj287
Merge pull request actions#30 from akamai/feature/DEVPOPS-789

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7162a08 
Updated message to display for origins with user variables
deining pushed a commit to deining/setup-node that referenced this issue Nov 9, 2023
@EndBug
Merge pull request actions#30 from ToMe25/master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c61b317 
Add tagging support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damccorm damccorm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update .gitignore actions/setup-node
2 participants
@fulldecent @damccorm