Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cache key should include node version #583

Closed
wants to merge 5 commits into from
Closed

fix: cache key should include node version #583

wants to merge 5 commits into from
+957 −950

Conversation

styfle
Copy link

@styfle styfle commented Sep 30, 2022 •
edited
Loading

Description:
Includes node version in the cache key. This fixes the issue where running in a matrix with multiple node versions would cause

Failed to save: Unable to reserve cache with key, another job may be creating this cache.

Related issue:

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Sorry, something went wrong.

@styfle styfle requested a review from a team September 30, 2022 19:13
@styfle styfle mentioned this pull request Sep 30, 2022
Closed
5 tasks
@dmitry-shibanov
Copy link
Contributor

I'm going to close the pull request because the initial issue was closed.

@styfle styfle deleted the fix-node-version-cache-key branch October 3, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to reserve cache with key node-cache-Linux-yarn, another job may be creating this cache
2 participants
@styfle @dmitry-shibanov