Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node.js mirror like nvm #730

Open
thomas-z-meyer-db opened this issue Mar 28, 2023 · 6 comments
Open

Support node.js mirror like nvm #730

thomas-z-meyer-db opened this issue Mar 28, 2023 · 6 comments
Labels
feature request New feature or request to improve the current logic

Comments

@thomas-z-meyer-db
Copy link

Description:
Support alternate nodejs download mirror like nvm

nvm does support setting a mirror via environment variable, e.g:
NVM_NODEJS_ORG_MIRROR=https://artifactory.company.com/artifactory/node-dist/

setup-node should also support a similar option "mirror" to specify an alternate node.js base URL for downloading the node.js binaries.

Justification:
All node.js binaries are downloaded directly from the internet via a specified proxy in the github action runners environment, which created egress costs for self-hosted github action runners in GHEC.

By using mirror option the reliance on node.js site is decoupled and egress is saved.

Are you willing to submit a PR?
i think i'm not allowed...

@thomas-z-meyer-db thomas-z-meyer-db added feature request New feature or request to improve the current logic needs triage labels Mar 28, 2023
@MaksimZhukov
Copy link
Contributor

Hello @thomas-z-meyer-db ! Thank you for the suggested idea!
We will consider adding this feature and will let you know as soon as we have any decision.

@Santas
Copy link

Santas commented Apr 12, 2023

nodejs.org seems to fail quite often in the recent weeks. Having a possibility to specify a mirror would be great.

@bgalek
Copy link

bgalek commented Jun 20, 2023

Hi! I'm also affected by nodejs.org fails.
Is setup-node action caching the node tarball, so it's not downloaded every time?
https://github.com/actions/toolkit/tree/main/packages/tool-cache

@dariusz22p
Copy link

NodeJs has been timing out a lot in recent days for us, so this feature would make our life much easier

@yeikel
Copy link

yeikel commented Sep 18, 2023

Is this feature open for OSS contributions?

@zhyc9de
Copy link

zhyc9de commented Sep 25, 2024

#134 can resolve this problom, can we merge it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

8 participants