Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mise version file support #787

Closed
pvinis opened this issue Jun 20, 2023 · 6 comments
Closed

mise version file support #787

pvinis opened this issue Jun 20, 2023 · 6 comments
Labels
feature request New feature or request to improve the current logic

Comments

@pvinis
Copy link

pvinis commented Jun 20, 2023

Description:
node-version-file should support rtx too. heres what .rtx.toml looks like

[tools]
yarn = "1.22.19"
nodejs = "18.16.0"

I saw the regex here doesn't work for this file.

Justification:
We support a few files, let's support one more popular one.

Are you willing to submit a PR?
Yes.
@pvinis pvinis added feature request New feature or request to improve the current logic needs triage labels Jun 20, 2023
@dmitry-shibanov
Copy link
Contributor

Hello @pvinis. Thank you for your feature request. We'll take a look at it.

@dusan-trickovic dusan-trickovic added investigation The issue is under investigation and removed needs eyes investigation The issue is under investigation labels Aug 3, 2023
@vincentbriglia
Copy link

't would be amazing if all the setup- actions could use RTX under the hood - but I also understand not wanting to be dependent on something that's not as popular as nvm, rbenv, etc ...

@vincentbriglia
Copy link

RTX has been renamed to MISE and you can see their action here: https://github.com/jdx/mise-action

@FezVrasta
Copy link

Is there any plan to support this?

@ssbarnea
Copy link

@pvinis Can you please rename the ticket title and description to use mise instead? It would make it less confusing.

@pvinis pvinis changed the title rtx verion file support mise version file support Feb 12, 2025
@pvinis
Copy link
Author

pvinis commented Feb 12, 2025

I'll just close it actually. the mise action is linked above.

@pvinis pvinis closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pvinis @ssbarnea @vincentbriglia @FezVrasta @dmitry-shibanov @dusan-trickovic