Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to use local tar.gz of node or from custom domain #837

Open
turkus opened this issue Aug 24, 2023 · 6 comments
Open

An option to use local tar.gz of node or from custom domain #837

turkus opened this issue Aug 24, 2023 · 6 comments
Labels
feature request New feature or request to improve the current logic needs eyes

Comments

@turkus
Copy link

turkus commented Aug 24, 2023

Description:
Thanks a lot for your great work. About the problem:
I had couple of times situation where public dist wasn't available and setup-node action had timeouts.

image

Justification:
In case of hotfixes we don't have much time, so my concern was to use local path as a path to the dist (tar.gz) or external URL (placed on my server) to download it.
Is there an any option to achieve smth like that even now?
I tried placing some dists under tool cache dirs, but doesn't work.

Thanks in advance,
turkus

@turkus turkus added feature request New feature or request to improve the current logic needs triage labels Aug 24, 2023
@dusan-trickovic
Copy link

Hello, @turkus! Thank you for creating this issue, I will do some investigation and get back to you with the response :)

@dusan-trickovic
Copy link

dusan-trickovic commented Aug 25, 2023

Hello again, @turkus! I just wanted to check with you if you've tried using self-hosted runners as well? You can find more about them in our docs, but basically they offer more control of hardware, operating system, and software tools than GitHub-hosted runners. This leaves a lot of room for customization in terms of architecture, OS, hardware and so on.

You could try installing your desired version of Node locally and setting up the runner as described in the docs and on the initial steps of creation. Provide the version you need to the workflow later and the runner on your machine should run.

Feel free to let us know if you have any follow-up questions or, alternatively, if our suggestion was what you were looking for.

Thank you very much for your time and cooperation :)

@turkus
Copy link
Author

turkus commented Aug 25, 2023

Thank you @dusan-trickovic for your response. Well it isn't about self-hosted runners. It's more like add an option in this setup-node library to give an option to use node dist from other source than node public dists, cause as you can see in other issues here in setup-node issues, that public node server gets timeouts and it occurs now often.
I suppose allowing to declare an option to provide local path to the node tar.gz would be fairly enough and not only for me - according to other similar issues.
Or URL to fetch.

@dusan-trickovic
Copy link

Hello again, @turkus ! I apologize for the late response. I understand what you mean now, I will discuss that option with the team and see what we can do about it :)

Thank you very much for your suggestion and cooperation!

@jakule
Copy link

jakule commented Oct 16, 2023

@dusan-trickovic Any updates on this? We're also affected by this issue. The node CDN is not very reliable recently.

@bertobert
Copy link

@jakule I tried the option with the tools cache and it worked for me - you will need to set the exact version in the setup-node step so it can be found. As a matter of fact I am using self-hosted runners but this should work the same on others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic needs eyes
Projects
None yet
Development

No branches or pull requests

4 participants