Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and fixes for ubuntu-latest change to ubuntu-24.04 #1144

Closed
wants to merge 15 commits into from
Prev Previous commit
Next Next commit
Update versions.yml
  • Loading branch information
aparnajyothi-y authored Sep 30, 2024
commit 9d6bd53ee58a21e4ec53ddb3843fb9c9303bc10a
6 changes: 3 additions & 3 deletions .github/workflows/versions.yml
Original file line number Diff line number Diff line change
@@ -53,9 +53,9 @@ jobs:
- if: runner.os != 'Windows' && runner.os != 'macOS'
name: Verify node and npm
run: |
. "$NVM_DIR/nvm.sh"
[[ $(nvm version-remote "${{ matrix.node-version }}") =~ ^v([^.]+) ]]
__tests__/verify-node.sh "${BASH_REMATCH[1]}"
node_version=$(node --version)
major_version=${node_version:1:2}
__tests__/verify-node.sh "$major_version"
shell: bash

v8-canary-syntax: