Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mirror-url parameter to allow downloading Node.js from a custom URL #1211

Closed
wants to merge 26 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
print
  • Loading branch information
aparnajyothi-y committed Jan 31, 2025
commit 17e88b6567a695a8cbc81e185dcff21c890e168a
6 changes: 4 additions & 2 deletions dist/setup/index.js
Original file line number Diff line number Diff line change
@@ -100154,10 +100154,12 @@ class BaseDistribution {
return response.result || [];
});
}
getMirrorUrVersions() {
getMirrorUrlVersions() {
return __awaiter(this, void 0, void 0, function* () {
const initialUrl = this.getDistributionMirrorUrl();
core.info('initialUrl from getDistributionMirrorUrl ' + initialUrl);
const dataUrl = `${initialUrl}/index.json`;
core.info('dataUrl from index ' + dataUrl);
const response = yield this.httpClient.getJson(dataUrl);
return response.result || [];
});
@@ -100726,7 +100728,7 @@ class OfficialBuilds extends base_distribution_1.default {
}
downloadFromMirrorURL() {
return __awaiter(this, void 0, void 0, function* () {
const nodeJsVersions = yield this.getMirrorUrVersions();
const nodeJsVersions = yield this.getMirrorUrlVersions();
core.info('nodeJsVersions from getMirrorUrVersions ' + nodeJsVersions);
const versions = this.filterVersions(nodeJsVersions);
core.info('versions from filterVersions ' + versions);
5 changes: 4 additions & 1 deletion src/distributions/base-distribution.ts
Original file line number Diff line number Diff line change
@@ -105,9 +105,12 @@ export default abstract class BaseDistribution {
return response.result || [];
}

protected async getMirrorUrVersions(): Promise<INodeVersion[]> {
protected async getMirrorUrlVersions(): Promise<INodeVersion[]> {
const initialUrl = this.getDistributionMirrorUrl();
core.info('initialUrl from getDistributionMirrorUrl '+initialUrl);

const dataUrl = `${initialUrl}/index.json`;
core.info('dataUrl from index '+dataUrl);

const response = await this.httpClient.getJson<INodeVersion[]>(dataUrl);
return response.result || [];
2 changes: 1 addition & 1 deletion src/distributions/official_builds/official_builds.ts
Original file line number Diff line number Diff line change
@@ -317,7 +317,7 @@ export default class OfficialBuilds extends BaseDistribution {
}

protected async downloadFromMirrorURL() {
const nodeJsVersions = await this.getMirrorUrVersions();
const nodeJsVersions = await this.getMirrorUrlVersions();
core.info('nodeJsVersions from getMirrorUrVersions '+nodeJsVersions);
const versions = this.filterVersions(nodeJsVersions);
core.info('versions from filterVersions '+versions);
Loading