Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mirror-url parameter to allow downloading Node.js from a custom URL #1211

Closed
wants to merge 26 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
aparnajyothi-y committed Jan 31, 2025
commit 7e57948fe0946c10db7c11b4f160487ecb752f40
11 changes: 5 additions & 6 deletions dist/setup/index.js
Original file line number Diff line number Diff line change
@@ -100156,7 +100156,7 @@ class BaseDistribution {
}
getMirrorUrlVersions() {
return __awaiter(this, void 0, void 0, function* () {
const initialUrl = this.getDistributionMirrorUrl();
const initialUrl = this.getDistributionUrl();
const dataUrl = `${initialUrl}/index.json`;
const response = yield this.httpClient.getJson(dataUrl);
return response.result || [];
@@ -100173,7 +100173,7 @@ class BaseDistribution {
? `${fileName}.zip`
: `${fileName}.7z`
: `${fileName}.tar.gz`;
const initialUrl = this.getDistributionMirrorUrl();
const initialUrl = this.getDistributionUrl();
const url = `${initialUrl}/v${version}/${urlFileName}`;
return {
downloadUrl: url,
@@ -100647,12 +100647,11 @@ class OfficialBuilds extends base_distribution_1.default {
return version;
}
getDistributionUrl() {
if (this.nodeInfo.mirrorURL) {
return this.nodeInfo.mirrorURL;
}
return `https://nodejs.org/dist`;
}
getDistributionMirrorUrl() {
const mirrorURL = this.nodeInfo.mirrorURL;
return mirrorURL !== null && mirrorURL !== void 0 ? mirrorURL : '';
}
getManifest() {
core.debug('Getting manifest from actions/node-versions@main');
return tc.getManifestFromRepo('actions', 'node-versions', this.nodeInfo.auth, 'main');
5 changes: 2 additions & 3 deletions src/distributions/base-distribution.ts
Original file line number Diff line number Diff line change
@@ -25,7 +25,6 @@ export default abstract class BaseDistribution {
}

protected abstract getDistributionUrl(): string;
protected abstract getDistributionMirrorUrl(): string;

public async setupNodeJs() {
let nodeJsVersions: INodeVersion[] | undefined;
@@ -106,7 +105,7 @@ export default abstract class BaseDistribution {
}

protected async getMirrorUrlVersions(): Promise<INodeVersion[]> {
const initialUrl = this.getDistributionMirrorUrl();
const initialUrl = this.getDistributionUrl();

const dataUrl = `${initialUrl}/index.json`;

@@ -127,7 +126,7 @@ export default abstract class BaseDistribution {
? `${fileName}.zip`
: `${fileName}.7z`
: `${fileName}.tar.gz`;
const initialUrl = this.getDistributionMirrorUrl();
const initialUrl = this.getDistributionUrl();
const url = `${initialUrl}/v${version}/${urlFileName}`;

return <INodeVersionInfo>{
10 changes: 4 additions & 6 deletions src/distributions/official_builds/official_builds.ts
Original file line number Diff line number Diff line change
@@ -193,14 +193,12 @@ export default class OfficialBuilds extends BaseDistribution {
}

protected getDistributionUrl(): string {
if (this.nodeInfo.mirrorURL) {
return this.nodeInfo.mirrorURL;
}
return `https://nodejs.org/dist`;
}

protected getDistributionMirrorUrl(): string {
const mirrorURL = this.nodeInfo.mirrorURL;

return mirrorURL ?? '';
}


private getManifest(): Promise<tc.IToolRelease[]> {
core.debug('Getting manifest from actions/node-versions@main');
Loading