Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mirror-url parameter to allow downloading Node.js from a custom URL #1232

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Prev Previous commit
Next Next commit
suppress warnings
  • Loading branch information
aparnajyothi-y committed Mar 4, 2025
commit d8619e6d5aba04fe134f4cda9fb329b0392264ff
5 changes: 0 additions & 5 deletions dist/setup/index.js
Original file line number Diff line number Diff line change
@@ -100516,10 +100516,6 @@ class OfficialBuilds extends base_distribution_1.default {
try {
core.info(`Attempting to download using mirror URL...`);
downloadPath = yield this.downloadFromMirrorURL(); // Attempt to download from the mirror
core.info('downloadPath from downloadFromMirrorURL() ' + downloadPath);
if (downloadPath) {
const toolPath = downloadPath;
}
}
catch (err) {
core.setFailed(err.message);
@@ -100528,7 +100524,6 @@ class OfficialBuilds extends base_distribution_1.default {
}
}
else {
core.info('No mirror URL found. Falling back to default setup...');
core.info('Setup Node.js');
let manifest;
let nodeJsVersions;
5 changes: 0 additions & 5 deletions src/distributions/official_builds/official_builds.ts
Original file line number Diff line number Diff line change
@@ -20,18 +20,13 @@

try {
core.info(`Attempting to download using mirror URL...`);
downloadPath = await this.downloadFromMirrorURL(); // Attempt to download from the mirror

Check warning on line 23 in src/distributions/official_builds/official_builds.ts

GitHub Actions / Basic validation / build (macos-latest)

'downloadPath' is assigned a value but never used

Check warning on line 23 in src/distributions/official_builds/official_builds.ts

GitHub Actions / Basic validation / build (ubuntu-latest)

'downloadPath' is assigned a value but never used

Check warning on line 23 in src/distributions/official_builds/official_builds.ts

GitHub Actions / Basic validation / build (windows-latest)

'downloadPath' is assigned a value but never used
core.info('downloadPath from downloadFromMirrorURL() ' + downloadPath);
if (downloadPath) {
const toolPath = downloadPath;
}
} catch (err) {
core.setFailed((err as Error).message);
core.setFailed('Download failed');
core.debug((err as Error).stack ?? 'empty stack');
}
} else {
core.info('No mirror URL found. Falling back to default setup...');
core.info('Setup Node.js');
let manifest: tc.IToolRelease[] | undefined;
let nodeJsVersions: INodeVersion[] | undefined;
Loading
Oops, something went wrong.