Default the scope from package.json#name #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
checking back on this spike to see if there's interest to continue |
|
I've rebased on latest and made the linter happy but this is as far as I can go. Right now some tests are failing (presumably) because the tests aren't running within the context of a package; so there's no package.json to require. |
|
nice feature! |
|
This please! |
deining
pushed a commit
to deining/setup-node
that referenced
this pull request
Nov 9, 2023
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Dochinds
approved these changes
Apr 20, 2024
|
Any way this can be moved forward? As noted in a comment to #128 , the scope input is still limiting the flexibility of this action in reusable workflows. |
|
Rebased, refactored to ESM, and added test. WDYT, @bryanmacfarlane ? |
yoyo956
approved these changes
May 29, 2024
jasonkarns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept attempt at #128