Add lts version #17
Add lts version #17
Conversation
| @@ -81,6 +85,18 @@ export async function getNode(versionSpec: string) { | |||
| core.addPath(toolPath); | |||
| } | |||
|
|
|||
| // Schedule based off https://nodejs.org/en/about/releases/. TODO: would be nice to automate this so we don't drift | |||
There was a problem hiding this comment.
What's the plan for this? Do we know how long of a buffer we have until the next LTS?
We should have an issue to track this and remove TODO from the code.
There was a problem hiding this comment.
I added an issue to add support for this in the node dist - nodejs/nodejs.org#2351
They seemed open to it, so I think that would be my ideal option 1. If that doesn't work, we could try to parse it somewhere, or just manually update as appropriate.
|
Is this a pattern we want to push across the boardr? Absense is LTS since that's what's on hosted so this change seems odd to me. |
| return '12.x'; | ||
| } | ||
| else { | ||
| return '14.x'; |
There was a problem hiding this comment.
There has to be a better way to do this by querying there releases and iterating to find latest LTS.
This seems like a maintenance problem.
There was a problem hiding this comment.
There's not right now as best I can tell, I filed an issue and the node people didn't have any better suggestions, I think that should change in the future.
This reverts commit 419dce7.
fix bug where name wasn't being validated properly
No description provided.