Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ncc compile source file as a single file #34

Closed
wants to merge 2 commits into from

Conversation

zcong1993
Copy link

@zcong1993 zcong1993 commented Aug 18, 2019

Use @zeit/ncc compile source file as a single file.
This can make git repo clean.

@damccorm
Copy link
Contributor

I don't think we want this - IMO this actually makes it less clear what is going on in the repo. I think the real solution here is to move to the workflow described here, where node_modules are only included on release branches

@zcong1993
Copy link
Author

zcong1993 commented Aug 19, 2019

Why this make less clear ? This solution can ignore node_modules even in release branches. Do you think the current compiled lib still readable or more clear than this ?

@damccorm
Copy link
Contributor

I think the current lib is more readable. It maintains the separation of concerns of different files, and maps to the TypeScript well. This is important so that a reviewer can verify that changes to the TS files match changes in the JS files.

@damccorm damccorm closed this Aug 19, 2019
krzyk pushed a commit to krzyk/setup-node that referenced this pull request Apr 11, 2023
deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
…-rises

docs: add jactor-rises as a contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants