Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use early return pattern in cache-utils.ts #643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −7
Open

refactor: Use early return pattern in cache-utils.ts #643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: Use early return pattern 
Signed-off-by: jongwooo <jongwooo.han@gmail.com>
  • Loading branch information
@jongwooo
jongwooo committed Dec 29, 2022
commit b1daf0a9afa1606e5a462753ded392e6f69b50ad
17 changes: 10 additions & 7 deletions src/cache-utils.ts
View file
Original file line number Diff line number Diff line change
@@ -63,21 +63,24 @@ const getPackageManagerVersion = async (
export const getPackageManagerInfo = async (packageManager: string) => {
if (packageManager === 'npm') {
return supportedPackageManagers.npm;
} else if (packageManager === 'pnpm') {
}

if (packageManager === 'pnpm') {
return supportedPackageManagers.pnpm;
} else if (packageManager === 'yarn') {
const yarnVersion = await getPackageManagerVersion('yarn', '--version');
}

if (packageManager === 'yarn') {
const yarnVersion = await getPackageManagerVersion('yarn', '--version');
core.debug(`Consumed yarn version is ${yarnVersion}`);

if (yarnVersion.startsWith('1.')) {
return supportedPackageManagers.yarn1;
} else {
return supportedPackageManagers.yarn2;
}
} else {
return null;

return supportedPackageManagers.yarn2;
}

return null;
};

export const getCacheDirectoryPath = async (