-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to enable corepack #651
Open
SayakMukhopadhyay
wants to merge
6
commits into
actions:main
Choose a base branch
from
SayakMukhopadhyay:corepack
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,161
−1,052
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b6efa7f
tests: add test to check for corepack enable call
SayakMukhopadhyay 53234c2
feat: add logic to enable corepack on passing optional input
SayakMukhopadhyay 41bb914
feat: build distributable
SayakMukhopadhyay 872987f
docs: add docs
SayakMukhopadhyay c7d2f5b
fix: apply suggestions from code review
SayakMukhopadhyay 0565a4f
feat: remove package manager name check as it will be done by corepac…
SayakMukhopadhyay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
feat: remove package manager name check as it will be done by corepac…
…k anyway
- Loading branch information
commit 0565a4fc0ab12102206331c8d8896b6ef4624ff9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -611,11 +611,6 @@ export async function enableCorepack(input: string): Promise<void> { | |
if (input.length > 0 && input !== 'false') { | ||
if (input !== 'true') { | ||
const packageManagers = input.split(' '); | ||
if (!packageManagers.every(pm => ['npm', 'yarn', 'pnpm'].includes(pm))) { | ||
throw new Error( | ||
`One or more of the specified package managers [ ${input} ] are not supported by corepack` | ||
); | ||
} | ||
corepackArgs.push(...packageManagers); | ||
} | ||
await exec.getExecOutput('corepack', corepackArgs, { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please, use |
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is enough to check
if (input.length && input !== 'false')