Add ci and fix linux tests #8
Conversation
.github/main.workflow
Outdated
|
|
||
| action "Test" { | ||
| needs = "Dependencies" | ||
| uses = "actions/npm@v2.0.0" |
There was a problem hiding this comment.
We need to test this on win, linux and mac.
There was a problem hiding this comment.
There was a problem hiding this comment.
Switched to azp for now to address this. I don't think I can grant azp access though since I'm not an admin of this repo.
|
I think we should look into how close we are to being able to use Dreamlifter Actions on this repo—would be a great opportunity for dog-fooding. |
|
I don't think we're there yet, but I agree as soon as that's possible we should do that. This is just to fill in until that point. |
|
I think I'm with @jclem on this one. I was on my run (where most ideas come from :) ) and I thought we could still use the dreamlifter yaml lang. We just need to flip on the feature flag in ring 0 (actually I think it's on). Chat with Eric Also, if we could get this action on the graph somehow, we could self host and test this action with this action :) Let's chat with Eric when I get in |
|
CI is up and running. Everything worked except for macOS which has a somewhat cryptic error inside one of the node modules - I think we should merge here and address that seperately. The node_module with the error was a Also, please ignore the mess of commits it took to get here, it took me a little bit to get the hang of the new syntax 😳 |
|
Everything is passing now, I'd be in favor of merging at this point. |
add account switch key internal parameter
No description provided.