Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to enable corepack #901

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Added option to enable corepack #901

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2936fe8
Added option to enable corepack (#1)
JP250552 Nov 21, 2023
7c0fdd0
test: updated tests
jrparish Nov 21, 2023
f9532b2
docs: node version
jrparish Nov 21, 2023
28c91a3
docs: actions versions
jrparish Nov 21, 2023
d8a8b93
docs: remove reference to experimental
jrparish Nov 21, 2023
802542b
Merge remote-tracking branch 'upstream/main' into feature/corepack
jrparish Dec 14, 2023
c871b9d
Merge remote-tracking branch 'upstream/main' into feature/corepack
jrparish Jan 2, 2024
c73bf90
fix: pr review adjustments
jrparish Feb 6, 2024
0c618ce
test: added e2e test, improved unit test
jrparish Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: actions versions
  • Loading branch information
@jrparish
jrparish committed Nov 21, 2023
commit 28c91a3bbc8c3f744ebc5b02f54ca99d68047620
8 changes: 4 additions & 4 deletions docs/advanced-usage.md
View file
Original file line number Diff line number Diff line change
@@ -422,8 +422,8 @@ You can enable [Corepack](https://github.com/nodejs/corepack) by using the `core

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18.x'
corepack: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the input corepack is not listed in /action.yml
did you forget to add it there?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is - https://github.com/actions/setup-node/pull/901/files#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6R28

@@ -435,8 +435,8 @@ You can also pass package manager names separated by a space to enable corepack

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18.x'
corepack: yarn pnpm